feat(fuzzer): Add VectorFuzzer::randTypeByWidth() #11800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D66968752 |
xiaoxmeng
reviewed
Dec 12, 2024
kagamiori
force-pushed
the
export-D66968752
branch
from
9a48281 to
2e5eae3
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 16, 2024
…11800) Summary: Add an API to allow generate a random type by the type width, i.e., the number of streams involved when reading or writing data of this type. Differential Revision: D66968752
|
This pull request was exported from Phabricator. Differential Revision: D66968752 |
xiaoxmeng
approved these changes
Dec 18, 2024
velox/vector/fuzzer/VectorFuzzer.cpp
Outdated
| FuzzerGenerator& rng, | ||
| const std::vector<TypePtr>& scalarTypes, | ||
| int minWidth) { | ||
| auto numFields = 1 + rand<uint32_t>(rng) % 10; |
velox/vector/fuzzer/VectorFuzzer.cpp
Outdated
| randTypeByWidth(rng, scalarTypes, minWidth - keyWidth - 1)); | ||
| } | ||
| // case 2: | ||
| default: { |
There was a problem hiding this comment.
remove {} like case 0 if there is no local var in the case statement
…11800) Summary: Add an API to allow generate a random type by the type width, i.e., the number of streams involved when reading or writing data of this type. Reviewed By: xiaoxmeng Differential Revision: D66968752
kagamiori
force-pushed
the
export-D66968752
branch
from
2e5eae3 to
8a118e5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66968752 |
|
This pull request has been merged in 3810d26. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…11800) Summary: Pull Request resolved: facebookincubator#11800 Add an API to allow generate a random type by the type width, i.e., the number of streams involved when reading or writing data of this type. Reviewed By: xiaoxmeng Differential Revision: D66968752 fbshipit-source-id: 0cddfdf6ec350c6f3c201bb993991cd4fec8f89e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add an API to allow generate a random type by the type width, i.e., the number of
streams involved when reading or writing data of this type.
Differential Revision: D66968752