fix(fuzzer): Ensure common dictionary generation skips row_number column #11821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Ensure that the row_number column, used for lining up results with the reference database, is not treated as a candidate for wrapping by the fuzzer's feature that probabilistically adds a common dictionary layer. This prevents verification mismatches caused by the column being wrapped and losing its intended purpose.
bikramSingh91
force-pushed
the
fuzzerBug
branch
from
d4d721d to
729e3c3
Compare
kagamiori
approved these changes
Dec 11, 2024
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@bikramSingh91 merged this pull request in 59d4741. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…umn (facebookincubator#11821) Summary: Ensure that the row_number column, used for lining up results with the reference database, is not treated as a candidate for wrapping by the fuzzer's feature that probabilistically adds a common dictionary layer. This prevents verification mismatches caused by the column being wrapped and losing its intended purpose. Pull Request resolved: facebookincubator#11821 Reviewed By: kagamiori Differential Revision: D67071154 Pulled By: bikramSingh91 fbshipit-source-id: 8051d264873fb74bc27064a64027ec72448131ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the row_number column, used for lining up results with the
reference database, is not treated as a candidate for wrapping by the
fuzzer's feature that probabilistically adds a common dictionary layer.
This prevents verification mismatches caused by the column being
wrapped and losing its intended purpose.