-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add query tracing blog #11865
docs: Add query tracing blog #11865
Conversation
✅ Deploy Preview for meta-velox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
751cdf3
to
8829636
Compare
@duanmeng the blog post reads pretty well, thanks for putting it together. As a thought: are we also adding it to the Velox docs? It would be nice to add the full version there so that people find it more easily in the future. One way we could organize this to prevent the blog post from being too dense, would be to move all the detailed information to a doc page (maybe this version could be the doc), and having a more condensed version as the blog post? This reads great, but it feels a bit long for a blog post - which is not necessarily bad. Wondering what other think - @mbasmanova @xiaoxmeng @Yuhta @majetideepak |
I haven't had a chance to read the text yet, but the suggestion above sounds great to me. |
@duanmeng Is this a copy of https://facebookincubator.github.io/velox/develop/debugging/tracing.html ? |
@pedroerp sounds good. @duanmeng could you make a short one and have reference to the detailed design doc? Thanks! |
I've moved all the detailed information to a tracing doc page and condensed the blog post. Could you please help take another look? Thanks. @xiaoxmeng @pedroerp @mbasmanova |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @duanmeng . Looks pretty good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duanmeng thanks for putting all the things together!
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@xiaoxmeng merged this pull request in 1bf58f4. |
Add a query tracing blog to the Velox website.
Original design doc, https://docs.google.com/document/d/1crIIeVz4tWKYQnBoHoxrv2i-4zAML9HSYLps8h5SDrc/edit?tab=t.0#heading=h.y6j2ojtr7hm9