Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add query tracing blog #11865

Closed
wants to merge 1 commit into from
Closed

Conversation

duanmeng
Copy link
Collaborator

@duanmeng duanmeng commented Dec 15, 2024

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 15, 2024
Copy link

netlify bot commented Dec 15, 2024

Deploy Preview for meta-velox ready!

Name Link
🔨 Latest commit 7c42028
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67642ff509afec0008bf6807
😎 Deploy Preview https://deploy-preview-11865--meta-velox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pedroerp
Copy link
Contributor

@duanmeng the blog post reads pretty well, thanks for putting it together. As a thought: are we also adding it to the Velox docs? It would be nice to add the full version there so that people find it more easily in the future.

One way we could organize this to prevent the blog post from being too dense, would be to move all the detailed information to a doc page (maybe this version could be the doc), and having a more condensed version as the blog post? This reads great, but it feels a bit long for a blog post - which is not necessarily bad.

Wondering what other think - @mbasmanova @xiaoxmeng @Yuhta @majetideepak

@mbasmanova
Copy link
Contributor

One way we could organize this to prevent the blog post from being too dense, would be to move all the detailed information to a doc page (maybe this version could be the doc), and having a more condensed version as the blog post?

I haven't had a chance to read the text yet, but the suggestion above sounds great to me.

@mbasmanova
Copy link
Contributor

@xiaoxmeng
Copy link
Contributor

@duanmeng the blog post reads pretty well, thanks for putting it together. As a thought: are we also adding it to the Velox docs? It would be nice to add the full version there so that people find it more easily in the future.

One way we could organize this to prevent the blog post from being too dense, would be to move all the detailed information to a doc page (maybe this version could be the doc), and having a more condensed version as the blog post? This reads great, but it feels a bit long for a blog post - which is not necessarily bad.

Wondering what other think - @mbasmanova @xiaoxmeng @Yuhta @majetideepak

@pedroerp sounds good. @duanmeng could you make a short one and have reference to the detailed design doc? Thanks!

@duanmeng
Copy link
Collaborator Author

I've moved all the detailed information to a tracing doc page and condensed the blog post. Could you please help take another look? Thanks. @xiaoxmeng @pedroerp @mbasmanova

Copy link
Contributor

@pedroerp pedroerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @duanmeng . Looks pretty good to me!

Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duanmeng thanks for putting all the things together!

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng merged this pull request in 1bf58f4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants