fix: Fix and improve table scan tracing and make to e2e work #11867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67258161 |
✅ Deploy Preview for meta-velox canceled.
|
duanmeng
approved these changes
Dec 16, 2024
…kincubator#11867) Summary: Make table scan tracing e2e work in Meta and fix issues found in existing table scan tracing plus improvement such as adding more stats to help analysis. This PR also add e2e testing for trace replay runner. Reviewed By: gggrace14 Differential Revision: D67258161
xiaoxmeng
force-pushed
the
export-D67258161
branch
from
72fd95b to
7bf14e7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67258161 |
|
This pull request has been merged in f1622ab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Make table scan tracing e2e work in Meta and fix issues found in existing table scan tracing
plus improvement such as adding more stats to help analysis.
This PR also add e2e testing for trace replay runner.
Differential Revision: D67258161