refactor: Remove unused and misleading Tree superclass #11873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `Tree` superclass is misleading (`size()` only counts direct children and iterator only iterates direct children; usually for such interface we would expect to iterate the whole tree) and not really used anywhere. Remove it to make the code base cleaner. Differential Revision: D67241802
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D67241802 |
zuyu
reviewed
Dec 16, 2024
| @@ -64,8 +64,8 @@ namespace { | |||
|
|
|||
| int countNodes(const TypePtr& type) { | |||
| int count = 1; | |||
| for (auto& child : *type) { | |||
| count += countNodes(child); | |||
| for (uint32_t end = type->size(), i = 0; i < end; ++i) { | |||
There was a problem hiding this comment.
for (uint32_t end = type->size(), i = 0; i < end; ++i) should have the same performance as for (uint32_t i = 0; i < type->size(); ++i), where end stores in a register, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The
Treesuperclass is misleading (size()only counts direct children and iterator only iterates direct children; usually for such interface we would expect to iterate the whole tree) and not really used anywhere. Remove it to make the code base cleaner.Differential Revision: D67241802