refactor: Simplify the partial full handling for distinct aggregation #11876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67288365 |
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Dec 17, 2024
…facebookincubator#11876) Summary: The current partial full is cleared when there is no new distinct in add input if it has been set. The reason for doing this is to avoid distinct partial aggregation hanging problem as we only reset the grouping set in case of partial full if there is new distinct found in get output. This is a bit tricky and it is better to handle reset partial full unconditionally in get output for distinct type of aggregation. Differential Revision: D67288365
xiaoxmeng
force-pushed
the
export-D67288365
branch
from
3917617 to
60d9362
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67288365 |
…facebookincubator#11876) Summary: We should have the case in aggregation add input that the partial aggregation has been marked as full but there is no new distinct detected for a distinct aggregation operator. Instead of clearing the partial full flag, we should add a distinct check there instead for simplicity. Differential Revision: D67288365
xiaoxmeng
force-pushed
the
export-D67288365
branch
from
60d9362 to
108cc0b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67288365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The current partial full is cleared when there is no new distinct in add input if it has been set.
The reason for doing this is to avoid distinct partial aggregation hanging problem
as we only reset the grouping set in case of partial full if there is new distinct found in get output.
This is a bit tricky and it is better to handle reset partial full unconditionally in get output for
distinct type of aggregation.
Differential Revision: D67288365