feat: Add task abortion test #11881
Open
feat: Add task abortion test #11881
+37
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67267972 |
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
@zation99 LGTM % minors. Please also have an review from @tanjialiang Thanks!
zation99
added a commit
to zation99/velox
that referenced
this pull request
Dec 17, 2024
Summary: A new thread to randomly tasks. It uses flag seconds_to_abort to control the frequency. Reviewed By: xiaoxmeng Differential Revision: D67267972
zation99
force-pushed
the
export-D67267972
branch
from
b8e89af to
f5e6175
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67267972 |
zation99
added a commit
to zation99/velox
that referenced
this pull request
Dec 17, 2024
Summary: A new thread to randomly tasks. It uses flag seconds_to_abort to control the frequency. Reviewed By: xiaoxmeng Differential Revision: D67267972
zation99
force-pushed
the
export-D67267972
branch
from
f5e6175 to
59c3877
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67267972 |
zation99
added a commit
to zation99/velox
that referenced
this pull request
Dec 18, 2024
Summary: A new thread to randomly tasks. It uses flag seconds_to_abort to control the frequency. Reviewed By: xiaoxmeng Differential Revision: D67267972
zation99
force-pushed
the
export-D67267972
branch
from
59c3877 to
48978e8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67267972 |
tanjialiang
reviewed
Dec 19, 2024
Comment on lines
856
to
872
| if (FLAGS_task_abort_interval_ms == 0) { | ||
| return; | ||
| } | ||
| while (!stop) { | ||
| std::this_thread::sleep_for( | ||
| std::chrono::milliseconds(FLAGS_task_abort_interval_ms)); | ||
| auto tasksList = Task::getRunningTasks(); | ||
| auto index = getRandomIndex(rng_, tasksList.size() - 1); | ||
| ++taskAbortRequestCount; | ||
| tasksList[index]->requestAbort(); | ||
| } |
There was a problem hiding this comment.
Shall we have error handling in this thread, by having a try and catch all block
There was a problem hiding this comment.
Also we can consider to use folly:FunctionScheduler to achieve the periodic scheduling of this task. It provides better functionality and encapsulations.
zation99
added a commit
to zation99/velox
that referenced
this pull request
Dec 19, 2024
Summary: A new thread to randomly tasks. It uses flag seconds_to_abort to control the frequency. Reviewed By: xiaoxmeng Differential Revision: D67267972
zation99
force-pushed
the
export-D67267972
branch
from
48978e8 to
4d5ad71
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67267972 |
Summary: A new thread to randomly tasks. It uses flag seconds_to_abort to control the frequency. Reviewed By: xiaoxmeng Differential Revision: D67267972
zation99
force-pushed
the
export-D67267972
branch
from
4d5ad71 to
fa37bf4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67267972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: A new thread to randomly tasks. It uses flag
task_abort_interval_msto control the frequency.Differential Revision: D67267972