Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Add support for row_constructor and dereference expressions in ToSqlUtil #11883

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinwilfong
Copy link
Contributor

Summary:
Support for row_constructor and dereference expressions were never added to ToSqlUtil. This file is used by
Fuzzer QueryRunners (particularly Presto) to generate SQL to execute. I'm guessing these features were
never used.

This is needed as part of enabling support for custom types not supported in DWRF files in Fuzzers
comparing agains Presto.

Differential Revision: D67310284

…ToSqlUtil

Summary:
Support for row_constructor and dereference expressions were never added to ToSqlUtil.  This file is used by
Fuzzer QueryRunners (particularly Presto) to generate SQL to execute. I'm guessing these features were
never used.

This is needed as part of enabling support for custom types not supported in DWRF files in Fuzzers
comparing agains Presto.

Differential Revision: D67310284
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 17, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67310284

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 7ae450a
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6760c9c2736b1f0008035b6d

kevinwilfong pushed a commit to kevinwilfong/velox that referenced this pull request Dec 17, 2024
…ToSqlUtil (facebookincubator#11883)

Summary:

Support for row_constructor and dereference expressions were never added to ToSqlUtil.  This file is used by
Fuzzer QueryRunners (particularly Presto) to generate SQL to execute. I'm guessing these features were
never used.

This is needed as part of enabling support for custom types not supported in DWRF files in Fuzzers
comparing agains Presto.

Differential Revision: D67310284
kevinwilfong pushed a commit to kevinwilfong/velox that referenced this pull request Dec 17, 2024
…ToSqlUtil (facebookincubator#11883)

Summary:

Support for row_constructor and dereference expressions were never added to ToSqlUtil.  This file is used by
Fuzzer QueryRunners (particularly Presto) to generate SQL to execute. I'm guessing these features were
never used.

This is needed as part of enabling support for custom types not supported in DWRF files in Fuzzers
comparing agains Presto.

Differential Revision: D67310284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants