fix(hdfs): Fix the failed unit tests in velox_hdfs_file_test #11884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
JkSelf
changed the title
JkSelf
force-pushed
the
hdfs-ci-failure
branch
2 times, most recently
from
20fb698 to
5f2b957
Compare
|
@majetideepak It seems that this issue is intermittent. I can't reproduce it locally, and it doesn't occur consistently on Velox CI either. |
|
@JkSelf It does look nondeterministic. The test seems to be passing now. |
JkSelf
force-pushed
the
hdfs-ci-failure
branch
from
5f2b957 to
b8bed20
Compare
@majetideepak Yes. I will close this pr. |
JkSelf
force-pushed
the
hdfs-ci-failure
branch
2 times, most recently
from
52cf355 to
c352bb2
Compare
JkSelf
force-pushed
the
hdfs-ci-failure
branch
from
c352bb2 to
6765a61
Compare
|
@majetideepak I have not yet identified the root cause. I suspect it may be due to the port being in use. I attempted to debug in the PR, but I was unable to reproduce the issue there. Do you have any suggestions |
JkSelf
force-pushed
the
hdfs-ci-failure
branch
from
6765a61 to
1f6bd74
Compare
|
@JkSelf I opened a PR here to fix the port issue https://github.com/facebookincubator/velox/pull/11996/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11857.