-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(hdfs): Cleanup header (#11585) #11891
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Dec 17, 2024
✅ Deploy Preview for meta-velox canceled.
|
majetideepak
changed the title
Revert "fix: Refactor package namespace in HdfsFileSystem (#11585)"
feat(revert): Refactor package namespace in HdfsFileSystem (#11585)
Dec 17, 2024
majetideepak
changed the title
feat(revert): Refactor package namespace in HdfsFileSystem (#11585)
fix(revert): Refactor package namespace in HdfsFileSystem (#11585)
Dec 17, 2024
majetideepak
force-pushed
the
revert-hdfs
branch
from
December 17, 2024 19:21
f229841
to
e8844b4
Compare
majetideepak
changed the title
fix(revert): Refactor package namespace in HdfsFileSystem (#11585)
fix: Cleanup hdfs header (#11585)
Dec 17, 2024
majetideepak
changed the title
fix: Cleanup hdfs header (#11585)
misc(hdfs): Cleanup header (#11585)
Dec 18, 2024
@JkSelf can you review this small change? Thanks. |
JkSelf
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your work.
JkSelf
approved these changes
Dec 19, 2024
majetideepak
added
the
ready-to-merge
PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
label
Dec 19, 2024
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
ready-to-merge
PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.