build: Do not enable all components when testing is enabled #11896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
czentgr
approved these changes
Dec 18, 2024
majetideepak
force-pushed
the
fix-cmake-testing
branch
from
e4d29d5 to
ccb4885
Compare
assignUser
approved these changes
Jan 6, 2025
assignUser
added
the
ready-to-merge
|
@majetideepak The build failure in the "Fuzzer Jobs" CI looks suspicious, it may be related to your changes. Regardless, could you rebase your change in case it's unrelated so I can merge it, it may also just be an old issue. |
majetideepak
force-pushed
the
fix-cmake-testing
branch
from
ccb4885 to
db7b271
Compare
|
@kevinwilfong It does look related. VELOX_ENABLE_PARQUET was always transitively enabled via VELOX_BUILD_TESTING (ON by default). I enabled Parquet by default now. |
|
This Spark Fuzzer failure is not related. |
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kevinwilfong merged this pull request in 1442bd5. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…incubator#11896) Summary: The goal is to improve the developer experience. If I want to build wave tests, I want to be able to only build the corresponding tests by disabling unrelated components such as Spark functions, TPC-H connector, etc. However, the current CMake setup enables these components when testing is enabled. All of these components except for examples are enabled by default. Pull Request resolved: facebookincubator#11896 Reviewed By: Yuhta Differential Revision: D67910097 Pulled By: kevinwilfong fbshipit-source-id: cc932b9397a6cb649ab12c0c1e1860dca75d4ff8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to improve the developer experience. If I want to build wave tests,
I want to be able to only build the corresponding tests by disabling unrelated
components such as Spark functions, TPC-H connector, etc. However, the current CMake setup enables these components when testing is enabled.
All of these components except for examples are enabled by default.