Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the correct index when doing comparison in custom view #11900

Closed

Conversation

yuandagits
Copy link
Contributor

Summary: We need to use the correct index inside the decoded vector when doing comparison.

Differential Revision: D67354078

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 0ff7a6d
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/676366833bdfe20008d51560

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67354078

Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuandagits thanks for the fix!

@@ -52,6 +52,10 @@ struct VectorReader {
explicit VectorReader(const VectorReader<T>&) = delete;
VectorReader<T>& operator=(const VectorReader<T>&) = delete;

vector_size_t index(vector_size_t idx) const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a unit test for this? thanks!

yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 17, 2024
…bookincubator#11900)

Summary:

We need to use the correct index inside the decoded vector when doing comparison.

Differential Revision: D67354078
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67354078

@yuandagits yuandagits requested a review from xiaoxmeng December 17, 2024 21:47
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuandagits LGTM. Thanks!

yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 18, 2024
…bookincubator#11900)

Summary:

We need to use the correct index inside the decoded vector when doing comparison.

Reviewed By: xiaoxmeng

Differential Revision: D67354078
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67354078

yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 18, 2024
…bookincubator#11900)

Summary:

We need to use the correct index inside the decoded vector when doing comparison.

Reviewed By: xiaoxmeng

Differential Revision: D67354078
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67354078

yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 18, 2024
…bookincubator#11900)

Summary:

We need to use the correct index inside the decoded vector when doing comparison.

Reviewed By: xiaoxmeng

Differential Revision: D67354078
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67354078

yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 18, 2024
…bookincubator#11900)

Summary:

We need to use the correct index inside the decoded vector when doing comparison.

Reviewed By: xiaoxmeng

Differential Revision: D67354078
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67354078

yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 18, 2024
…bookincubator#11900)

Summary:

We need to use the correct index inside the decoded vector when doing comparison.

Reviewed By: xiaoxmeng

Differential Revision: D67354078
yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 18, 2024
…bookincubator#11900)

Summary:

We need to use the correct index inside the decoded vector when doing comparison.

Reviewed By: xiaoxmeng

Differential Revision: D67354078
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67354078

…bookincubator#11900)

Summary:

We need to use the correct index inside the decoded vector when doing comparison.

Reviewed By: xiaoxmeng

Differential Revision: D67354078
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67354078

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 46c71b7.

athmaja-n pushed a commit to athmaja-n/velox that referenced this pull request Jan 10, 2025
…bookincubator#11900)

Summary:
Pull Request resolved: facebookincubator#11900

We need to use the correct index inside the decoded vector when doing comparison.

Reviewed By: xiaoxmeng

Differential Revision: D67354078

fbshipit-source-id: 59de192b25fa25eb12185070cfab76e4888da518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants