fix: Use the correct index when doing comparison in custom view #11900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D67354078 |
xiaoxmeng
reviewed
Dec 17, 2024
| @@ -52,6 +52,10 @@ struct VectorReader { | |||
| explicit VectorReader(const VectorReader<T>&) = delete; | |||
| VectorReader<T>& operator=(const VectorReader<T>&) = delete; | |||
|
|
|||
| vector_size_t index(vector_size_t idx) const { | |||
There was a problem hiding this comment.
Can we have a unit test for this? thanks!
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 17, 2024
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Differential Revision: D67354078
yuandagits
force-pushed
the
export-D67354078
branch
from
341d5c9 to
740ea85
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67354078 |
xiaoxmeng
approved these changes
Dec 17, 2024
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 18, 2024
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
yuandagits
force-pushed
the
export-D67354078
branch
from
740ea85 to
c8e1298
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67354078 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 18, 2024
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
yuandagits
force-pushed
the
export-D67354078
branch
from
c8e1298 to
92f8a60
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67354078 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 18, 2024
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
yuandagits
force-pushed
the
export-D67354078
branch
from
92f8a60 to
fb1c947
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67354078 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 18, 2024
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
yuandagits
force-pushed
the
export-D67354078
branch
from
fb1c947 to
2956413
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67354078 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 18, 2024
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 18, 2024
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
yuandagits
force-pushed
the
export-D67354078
branch
from
2956413 to
09bc52c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67354078 |
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
yuandagits
force-pushed
the
export-D67354078
branch
from
09bc52c to
0ff7a6d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67354078 |
|
This pull request has been merged in 46c71b7. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…bookincubator#11900) Summary: Pull Request resolved: facebookincubator#11900 We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078 fbshipit-source-id: 59de192b25fa25eb12185070cfab76e4888da518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We need to use the correct index inside the decoded vector when doing comparison.
Differential Revision: D67354078