-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use the correct index when doing comparison in custom view #11900
Conversation
✅ Deploy Preview for meta-velox canceled.
|
This pull request was exported from Phabricator. Differential Revision: D67354078 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuandagits thanks for the fix!
@@ -52,6 +52,10 @@ struct VectorReader { | |||
explicit VectorReader(const VectorReader<T>&) = delete; | |||
VectorReader<T>& operator=(const VectorReader<T>&) = delete; | |||
|
|||
vector_size_t index(vector_size_t idx) const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a unit test for this? thanks!
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Differential Revision: D67354078
341d5c9
to
740ea85
Compare
This pull request was exported from Phabricator. Differential Revision: D67354078 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuandagits LGTM. Thanks!
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
740ea85
to
c8e1298
Compare
This pull request was exported from Phabricator. Differential Revision: D67354078 |
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
c8e1298
to
92f8a60
Compare
This pull request was exported from Phabricator. Differential Revision: D67354078 |
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
92f8a60
to
fb1c947
Compare
This pull request was exported from Phabricator. Differential Revision: D67354078 |
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
fb1c947
to
2956413
Compare
This pull request was exported from Phabricator. Differential Revision: D67354078 |
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
2956413
to
09bc52c
Compare
This pull request was exported from Phabricator. Differential Revision: D67354078 |
…bookincubator#11900) Summary: We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078
09bc52c
to
0ff7a6d
Compare
This pull request was exported from Phabricator. Differential Revision: D67354078 |
This pull request has been merged in 46c71b7. |
…bookincubator#11900) Summary: Pull Request resolved: facebookincubator#11900 We need to use the correct index inside the decoded vector when doing comparison. Reviewed By: xiaoxmeng Differential Revision: D67354078 fbshipit-source-id: 59de192b25fa25eb12185070cfab76e4888da518
Summary: We need to use the correct index inside the decoded vector when doing comparison.
Differential Revision: D67354078