-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Setup nightly run of cache fuzzer #11901
Conversation
✅ Deploy Preview for meta-velox canceled.
|
This pull request was exported from Phabricator. Differential Revision: D67356608 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits: looks good.
.github/workflows/scheduled.yml
Outdated
- name: Upload cache fuzzer | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give it a more relevant name , like cache-fuzzer-artifact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following the naming style like others in the file. Ex: window, join, aggregation etc. Do you recommend changing this still, may be call it "cache-fuzzer"?
.github/workflows/scheduled.yml
Outdated
|
||
- name: Run cache Fuzzer | ||
run: | | ||
cat /proc/sys/vm/max_map_count |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit why the cat ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
Summary: Pull Request resolved: facebookincubator#11901 Reviewed By: kgpai Differential Revision: D67356608
3554770
to
3fe2732
Compare
This pull request was exported from Phabricator. Differential Revision: D67356608 |
This pull request has been merged in 2e94f95. |
Differential Revision: D67356608