Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Setup nightly run of cache fuzzer #11901

Closed
wants to merge 1 commit into from

Conversation

kKPulla
Copy link
Contributor

@kKPulla kKPulla commented Dec 17, 2024

Differential Revision: D67356608

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 3fe2732
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/676208b47c3c9f00083bf2e2

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67356608

Copy link
Contributor

@kgpai kgpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits: looks good.

- name: Upload cache fuzzer
uses: actions/upload-artifact@v4
with:
name: cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give it a more relevant name , like cache-fuzzer-artifact

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following the naming style like others in the file. Ex: window, join, aggregation etc. Do you recommend changing this still, may be call it "cache-fuzzer"?


- name: Run cache Fuzzer
run: |
cat /proc/sys/vm/max_map_count
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit why the cat ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Summary: Pull Request resolved: facebookincubator#11901

Reviewed By: kgpai

Differential Revision: D67356608
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67356608

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 2e94f95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants