fix(build): Add remote function benchmark under benchmark flags #11905
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
| @@ -16,4 +16,6 @@ add_subdirectory(if) | |||
| add_subdirectory(client) | |||
| add_subdirectory(server) | |||
| add_subdirectory(utils) | |||
| if(${VELOX_ENABLE_BENCHMARKS} OR ${VELOX_ENABLE_BENCHMARKS_BASIC}) | |||
There was a problem hiding this comment.
${VELOX_ENABLE_BENCHMARKS} should be sufficient.
czentgr
force-pushed
the
cz_fix_remote_func_benchmark_build
branch
from
45e1240 to
2cd7668
Compare
The remote function benchmarks are built without checking if the benchmark utilities are being built. These are only built if certain flags are set. This causes upstream issues in Prestissimo because there remote functions are being built but the benchmarks are not. PR introducing the breaking change: facebookincubator#11539
czentgr
force-pushed
the
cz_fix_remote_func_benchmark_build
branch
from
2cd7668 to
9c4d3b9
Compare
majetideepak
approved these changes
Dec 18, 2024
majetideepak
added
the
ready-to-merge
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remote function benchmarks are built without checking if the benchmark utilities are being built. These are only built if certain flags are set.
This causes upstream issues in Prestissimo because there remote functions are being built but the benchmarks are not.
PR introducing the breaking change:
#11539