misc(revert): Backout Add toString() to OutputBuffer stats (#11562)
#11906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67403265 |
✅ Deploy Preview for meta-velox canceled.
|
|
@kgpai The test added needs to be removed |
…kincubator#11562) (facebookincubator#11906) Summary: Backing out D67304118: Add toString() to OutputBuffer stats since it breaks certain tests : https://github.com/facebookincubator/velox/actions/runs/12305614280/job/34345592257 . Differential Revision: D67403265
kgpai
force-pushed
the
export-D67403265
branch
from
4822827 to
6973ee2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67403265 |
majetideepak
approved these changes
Dec 18, 2024
|
This pull request has been merged in fdb309f. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…kincubator#11562) (facebookincubator#11906) Summary: Pull Request resolved: facebookincubator#11906 Backing out D67304118: Add toString() to OutputBuffer stats since it breaks certain tests : https://github.com/facebookincubator/velox/actions/runs/12305614280/job/34345592257 . Reviewed By: bikramSingh91 Differential Revision: D67403265 fbshipit-source-id: 8c0723b2748645e88a68ddf57c2b1cc5dbbb2095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Backing out D67304118: Add toString() to OutputBuffer stats since it breaks certain tests : https://github.com/facebookincubator/velox/actions/runs/12305614280/job/34345592257 .
Differential Revision: D67403265