fix: Fix flaky tsan failure in async data cache #11908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67378594 |
✅ Deploy Preview for meta-velox canceled.
|
kagamiori
approved these changes
Dec 18, 2024
xiaoxmeng
force-pushed
the
export-D67378594
branch
from
196b6f0 to
0180efe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67378594 |
zacw7
approved these changes
Dec 19, 2024
|
This pull request has been merged in cf2ba83. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
) Summary: Pull Request resolved: facebookincubator#11908 Mark refresh stats method to avoid tsan check to see if it can prevent tsan failure. The refresh stats will access the entries which are under initialization and it is read only has not pointer chasing so it is safe to do so. Reviewed By: kagamiori, zacw7 Differential Revision: D67378594 fbshipit-source-id: 38cae1d9204880639da95c8ae9a7bcf37e471262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Mark refresh stats method to avoid tsan check to see if it can prevent tsan failure. The refresh stats will access the
entries which are under initialization and it is read only has not pointer chasing so it is safe to do so.
Differential Revision: D67378594