fix: Fix columns stats when insert serialized rows #11910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67419701 |
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
approved these changes
Dec 18, 2024
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Dec 18, 2024
Summary: We don't update column stats when insert serialized rows which could cause problem when extract data from the row container as deserialized vector which depends on the column stats in the row container. This PR adds column stats update for serialized row insertion Reviewed By: Yuhta Differential Revision: D67419701
xiaoxmeng
force-pushed
the
export-D67419701
branch
from
a2bb719 to
4c98b7f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67419701 |
…#11910) Summary: We don't update column stats when insert serialized rows which could cause problem when extract data from the row container as deserialized vector which depends on the column stats in the row container. This PR adds column stats update for serialized row insertion Reviewed By: Yuhta Differential Revision: D67419701
xiaoxmeng
force-pushed
the
export-D67419701
branch
from
4c98b7f to
5a26064
Compare
xiaoxmeng
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D67419701 |
zhli1142015
approved these changes
Dec 19, 2024
|
This pull request has been merged in 67e858c. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…#11910) Summary: Pull Request resolved: facebookincubator#11910 We don't update column stats when insert serialized rows which could cause problem when extract data from the row container as deserialized vector which depends on the column stats in the row container. This PR adds column stats update for serialized row insertion Reviewed By: Yuhta Differential Revision: D67419701 fbshipit-source-id: dc243f6b4f0af6979103667922c13ad0ed89b8d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We don't update column stats when insert serialized rows which could cause problem when extract data
from the row container as deserialized vector which depends on the column stats in the row container.
This PR adds column stats update for serialized row insertion
Differential Revision: D67419701