fix(runner): Fix broadcast in LocalRunner #11923
Open
+73
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff adds a unit test of LocalRunner with a broadcast node in the query plan and fixes the handling of broadcast in LocalRunner. Differential Revision: D67549347
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67549347 |
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
reviewed
Dec 23, 2024
| VELOX_CHECK_NOT_NULL(output); | ||
| const auto producerPrefix = current_->taskPrefix; | ||
| auto result = planNode_; | ||
| newFragment(); |
There was a problem hiding this comment.
Leave an empty line here.
| root_->stack_.pop_back(); | ||
| auto* consumer = root_->stack_.back(); | ||
| fragments_.back().numBroadcastDestinations = consumer->current_->width; | ||
| VELOX_CHECK_GE(consumer->current_->width, 1); |
There was a problem hiding this comment.
We should check width before its use, and we shall also check numBroadcastDestinations is not set in the previous fragment yet.
| } | ||
| exchange(output->outputType(), VectorSerde::Kind::kPresto); | ||
| auto* exchange = dynamic_cast<const core::ExchangeNode*>(planNode_.get()); | ||
| consumer->current_->inputStages.push_back( |
There was a problem hiding this comment.
add a non null check on exchange after cast
| @@ -108,6 +108,29 @@ core::PlanNodePtr DistributedPlanBuilder::shuffleResult( | |||
| return std::move(planNode_); | |||
| } | |||
|
|
|||
| core::PlanNodePtr DistributedPlanBuilder::broadcastResult() { | |||
There was a problem hiding this comment.
Shall we call this shuffleBroadcastResult? And rename the existing one to shufflePartitionedResult?
| const auto producerPrefix = current_->taskPrefix; | ||
| auto result = planNode_; | ||
| newFragment(); | ||
| root_->stack_.pop_back(); |
There was a problem hiding this comment.
Can we check if stack is empty on dtor? And we should expect stack is not empty when calling non-result APIs from DistributedPlanBuilder? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff adds a unit test of LocalRunner with a broadcast node in the query plan and fixes the handling of broadcast in LocalRunner.
Differential Revision: D67549347