Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use MemoryManager::testInstance to check the MemoryManager initialization #11926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Use MemoryManager::testInstance to check the MemoryManager initialization #11926

wants to merge 1 commit into from

Conversation

duanmeng
Copy link
Collaborator

@duanmeng duanmeng commented Dec 21, 2024 •
edited
Loading

Use MemoryManager::testInstance to check whether the MemoryManager
is initialized in TraceReplayRunner.cpp instead of memory::memoryManager()
as it uses MemoryManager::instance, which would throw if the MemoryManager
instance is null.

@duanmeng duanmeng requested a review from xiaoxmeng December 21, 2024 12:41
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 21, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 21, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit a5aede3
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6766b77c84fbad0008bd3cc4

@facebook-github-bot
Copy link
Contributor

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxmeng xiaoxmeng xiaoxmeng approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duanmeng @facebook-github-bot @xiaoxmeng