refactor: Remove ::test namespace from cursor.h #12014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67775554 |
✅ Deploy Preview for meta-velox canceled.
|
zation99
changed the title
zation99
added a commit
to zation99/presto
that referenced
this pull request
Jan 3, 2025
Summary: X-link: facebookincubator/velox#12014 The methods/classes in cusor.h should not be in ::test namespace. Updated the declaration as well as all the references. Reviewed By: xiaoxmeng Differential Revision: D67775554
xiaoxmeng
approved these changes
Jan 3, 2025
zation99
added a commit
to zation99/velox
that referenced
this pull request
Jan 3, 2025
Summary: X-link: prestodb/presto#24319 The methods/classes in cusor.h should not be in ::test namespace. Updated the declaration as well as all the references. Reviewed By: xiaoxmeng Differential Revision: D67775554
zation99
force-pushed
the
export-D67775554
branch
from
9ad3184 to
ee9fe3a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67775554 |
zation99
force-pushed
the
export-D67775554
branch
from
ee9fe3a to
442443c
Compare
zation99
added a commit
to zation99/velox
that referenced
this pull request
Jan 3, 2025
Summary: X-link: prestodb/presto#24319 The methods/classes in cusor.h should not be in ::test namespace. Updated the declaration as well as all the references. Reviewed By: xiaoxmeng Differential Revision: D67775554
|
This pull request was exported from Phabricator. Differential Revision: D67775554 |
Summary: X-link: prestodb/presto#24319 The methods/classes in cusor.h should not be in ::test namespace. Updated the declaration as well as all the references. Reviewed By: xiaoxmeng Differential Revision: D67775554
zation99
force-pushed
the
export-D67775554
branch
from
442443c to
f980c73
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67775554 |
|
This pull request has been merged in 3e79fdb. |
6 tasks
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: X-link: prestodb/presto#24319 Pull Request resolved: facebookincubator#12014 The methods/classes in cusor.h should not be in ::test namespace. Updated the declaration as well as all the references. Reviewed By: xiaoxmeng Differential Revision: D67775554 fbshipit-source-id: 4bec61df506ca3e8ca7e51d52d6f4cfdabfd6728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The methods/classes in cusor.h should not be in ::test namespace. Updated the declaration as well as all the references.
Reviewed By: xiaoxmeng
Differential Revision: D67775554