fix: Avoid redownload coalesced region gap twice in buffered inputs #12018
+235
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In the current `DirectBufferedInput` and `CachedBufferedInput`, when we coalesce some regions during prefetch, the gap between regions are not marked as available, and if they are needed in adhoc streams, we would issue separate IOs for them, resulting in unnecessary IOs. This change fixes this by rearranging the regions and loads generation logic, first generate and group the prefetch regions, then we can compare the coalesced regions to the adhoc regions and move those already coalesced to the prefetch loads, reducing the number of adhoc IOs. Differential Revision: D67810195
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D67810195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In the current
DirectBufferedInputandCachedBufferedInput, when wecoalesce some regions during prefetch, the gap between regions are not marked as
available, and if they are needed in adhoc streams, we would issue separate IOs
for them, resulting in unnecessary IOs. This change fixes this by rearranging
the regions and loads generation logic, first generate and group the prefetch
regions, then we can compare the coalesced regions to the adhoc regions and move
those already coalesced to the prefetch loads, reducing the number of adhoc IOs.
Differential Revision: D67810195