Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testReadFromFiles in testAggregations #6852

Closed
wants to merge 1 commit into from

Conversation

kagamiori
Copy link
Contributor

Differential Revision: D48737844

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 6c49625
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/651f49b1e37a1100080e5d6f

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48737844

kagamiori added a commit to kagamiori/velox that referenced this pull request Oct 5, 2023
Summary: Pull Request resolved: facebookincubator#6852

Reviewed By: Yuhta

Differential Revision: D48737844
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48737844

kagamiori added a commit to kagamiori/velox that referenced this pull request Oct 5, 2023
Summary: Pull Request resolved: facebookincubator#6852

Reviewed By: Yuhta

Differential Revision: D48737844
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48737844

Summary: Pull Request resolved: facebookincubator#6852

Reviewed By: Yuhta

Differential Revision: D48737844
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48737844

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in cafd379.

@conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit cafd3790.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

ericyuliu pushed a commit to ericyuliu/velox that referenced this pull request Oct 12, 2023
Summary: Pull Request resolved: facebookincubator#6852

Reviewed By: Yuhta

Differential Revision: D48737844

fbshipit-source-id: c742d1e89d0b01788070e519a1227a6a89816958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants