Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundled build linking failure with Parquet ON #6863

Closed

Conversation

nmahadevuni
Copy link
Collaborator

@nmahadevuni nmahadevuni commented Oct 3, 2023

Fixes #6744

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 6ca54b8
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/651e91f570e8ab00085c9807

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2023
@nmahadevuni nmahadevuni force-pushed the bundle_build_failure branch 2 times, most recently from 2b80199 to 7d261e0 Compare October 3, 2023 12:59
@majetideepak
Copy link
Collaborator

@nmahadevuni, can you explain the fix? I only see a new CI job here.

@nmahadevuni
Copy link
Collaborator Author

@nmahadevuni, can you explain the fix? I only see a new CI job here.

Sorry, its WIP. Was building without fix to see it fails with the same error. Will update with the fix soon

@nmahadevuni nmahadevuni changed the title Fix bundled build linking failure with Parquet ON WIP: Fix bundled build linking failure with Parquet ON Oct 3, 2023
@majetideepak majetideepak marked this pull request as draft October 3, 2023 15:04
@nmahadevuni nmahadevuni force-pushed the bundle_build_failure branch 2 times, most recently from 91e4a32 to 0dc7665 Compare October 3, 2023 18:25
@nmahadevuni
Copy link
Collaborator Author

@majetideepak The linux build option I added fails in 25 mins with collect2: fatal error: ld terminated with signal 9 [Killed]. Can't find the reason anywhere. The timeout is 1 hour. Any idea what's happening here?

@nmahadevuni nmahadevuni force-pushed the bundle_build_failure branch 2 times, most recently from 2060138 to 6ca54b8 Compare October 5, 2023 10:37
@majetideepak
Copy link
Collaborator

majetideepak commented Oct 5, 2023

collect2: fatal error: ld terminated with signal 9 [Killed]

@nmahadevuni This is likely due to the linker not having enough memory. Try reducing the number of parallel link jobs.

@nmahadevuni
Copy link
Collaborator Author

collect2: fatal error: ld terminated with signal 9 [Killed]

@nmahadevuni This is likely due to the linker not having enough memory. Try reducing the number of parallel link jobs.

Thanks. I have removed the CI job commit. Its a very long job too. I verified it building locally that the fix works. Can you review this?

@nmahadevuni nmahadevuni changed the title WIP: Fix bundled build linking failure with Parquet ON Fix bundled build linking failure with Parquet ON Oct 10, 2023
Copy link

stale bot commented Jan 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

@stale stale bot added the stale label Jan 8, 2024
@stale stale bot closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined reference to `typeinfo for google::protobuf::io::ZeroCopyOutputStream' after #5914
3 participants