Optimize DateType::toString(int32_t) and functions::getDateTime #6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49940219 |
Yuhta
force-pushed
the
export-D49940219
branch
from
5bd2eca to
7067923
Compare
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Oct 5, 2023
…bookincubator#6913) Summary: Optimize `DateType::toString(int32_t)` and `functions::getDateTime` by reusing the same optimization we did for `Timestamp::toString`. Fix facebookincubator#6918 Reviewed By: oerling Differential Revision: D49940219
|
This pull request was exported from Phabricator. Differential Revision: D49940219 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Oct 5, 2023
…bookincubator#6913) Summary: Optimize `DateType::toString(int32_t)` and `functions::getDateTime` by reusing the same optimization we did for `Timestamp::toString`. Fix facebookincubator#6918 Reviewed By: oerling Differential Revision: D49940219
Yuhta
force-pushed
the
export-D49940219
branch
from
7067923 to
584c3ea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49940219 |
…bookincubator#6913) Summary: Optimize `DateType::toString(int32_t)` and `functions::getDateTime` by reusing the same optimization we did for `Timestamp::toString`. Fix facebookincubator#6918 Reviewed By: oerling Differential Revision: D49940219
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Oct 5, 2023
…bookincubator#6913) Summary: Optimize `DateType::toString(int32_t)` and `functions::getDateTime` by reusing the same optimization we did for `Timestamp::toString`. Fix facebookincubator#6918 Reviewed By: oerling Differential Revision: D49940219
Yuhta
force-pushed
the
export-D49940219
branch
from
584c3ea to
ab24e62
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49940219 |
Yuhta
force-pushed
the
export-D49940219
branch
from
ab24e62 to
36cf896
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49940219 |
|
This pull request has been merged in 9662927. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
…bookincubator#6913) Summary: Pull Request resolved: facebookincubator#6913 Optimize `DateType::toString(int32_t)` and `functions::getDateTime` by reusing the same optimization we did for `Timestamp::toString`. Fix facebookincubator#6918 Reviewed By: oerling Differential Revision: D49940219 fbshipit-source-id: 8ed16d140514f64cebade6ffe20f205a8187ece2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Optimize
DateType::toString(int32_t)andfunctions::getDateTimeby reusing the same optimization we did forTimestamp::toString.Differential Revision: D49940219
Fix #6918