Add support to write to ABFS filesystems. #7218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
gaoyangxiaozhu
changed the title
gaoyangxiaozhu
force-pushed
the
gayangya/abfs-connector-write
branch
from
c7ee0e0 to
568289d
Compare
kgpai
reviewed
Nov 1, 2023
|
cc: @majetideepak |
added 2 commits
November 6, 2023 16:05
|
@gaoyangxiaozhu Can you move the dependency change to a separate PR? |
majetideepak
reviewed
Nov 6, 2023
majetideepak
reviewed
Nov 6, 2023
majetideepak
reviewed
Nov 6, 2023
velox/connectors/hive/storage_adapters/abfs/tests/AbfsFileSystemTest.cpp
Outdated
Show resolved
Hide resolved
sure, will do |
hey @majetideepak i send seperate PR for dependency change as you suggested #7688 could you help reivew ? |
zhli1142015
reviewed
Dec 25, 2023
|
@gaoyangxiaozhu is this ready for review? |
yes @majetideepak please, thank you! |
added 2 commits
February 3, 2024 20:36
…yangya/velox into gayangya/abfs-connector-write
majetideepak
reviewed
Feb 5, 2024
velox/connectors/hive/storage_adapters/abfs/tests/MockBlobStorageFileClient.cpp
Show resolved
Hide resolved
velox/connectors/hive/storage_adapters/abfs/tests/AbfsFileSystemTest.cpp
Outdated
Show resolved
Hide resolved
velox/connectors/hive/storage_adapters/abfs/tests/AbfsFileSystemTest.cpp
Outdated
Show resolved
Hide resolved
velox/connectors/hive/storage_adapters/abfs/tests/AbfsFileSystemTest.cpp
Outdated
Show resolved
Hide resolved
velox/connectors/hive/storage_adapters/abfs/tests/AbfsFileSystemTest.cpp
Outdated
Show resolved
Hide resolved
majetideepak
reviewed
Feb 6, 2024
majetideepak
approved these changes
Feb 7, 2024
|
@pedroerp can you help merge this? Thanks. |
|
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kgpai
approved these changes
Feb 8, 2024
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
FelixYBW
pushed a commit
to FelixYBW/velox
that referenced
this pull request
Feb 12, 2024
Summary: This change adds support to write from Abfs (Azure Gen2 Storage). It's part of work related to issue facebookincubator#6415 Pull Request resolved: facebookincubator#7218 Reviewed By: kgpai Differential Revision: D53577232 Pulled By: pedroerp fbshipit-source-id: bea93e2f1c2cff6762d435f6a99b67a494664cf2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support to write from Abfs (Azure Gen2 Storage).
It's part of work related to issue #6415