Create ExpressionFuzzerVerifier::Options and move all flags to FuzzerRunner #7634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 20, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Differential Revision: D51417731
laithsakka
force-pushed
the
export-D51417731
branch
from
3807d32 to
da5e188
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 20, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Differential Revision: D51417731
laithsakka
force-pushed
the
export-D51417731
branch
from
da5e188 to
b8fe3d0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 20, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Differential Revision: D51417731
laithsakka
force-pushed
the
export-D51417731
branch
from
b8fe3d0 to
76bb87c
Compare
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 20, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Differential Revision: D51417731
laithsakka
force-pushed
the
export-D51417731
branch
from
76bb87c to
f4a0898
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 20, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Differential Revision: D51417731
laithsakka
force-pushed
the
export-D51417731
branch
from
f4a0898 to
7583603
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 20, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Differential Revision: D51417731
laithsakka
force-pushed
the
export-D51417731
branch
from
7583603 to
63c189f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
force-pushed
the
export-D51417731
branch
from
63c189f to
8c33293
Compare
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 27, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Differential Revision: D51417731
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 28, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Differential Revision: D51417731
laithsakka
force-pushed
the
export-D51417731
branch
from
8c33293 to
7871fe3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
force-pushed
the
export-D51417731
branch
from
7871fe3 to
0e62ea5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Dec 4, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Differential Revision: D51417731
laithsakka
force-pushed
the
export-D51417731
branch
from
ae59cff to
36507bb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
force-pushed
the
export-D51417731
branch
from
36507bb to
ebafcf5
Compare
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Dec 4, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Reviewed By: kevinwilfong Differential Revision: D51417731
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Dec 4, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Reviewed By: kevinwilfong Differential Revision: D51417731
laithsakka
force-pushed
the
export-D51417731
branch
from
ebafcf5 to
d928c50
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
force-pushed
the
export-D51417731
branch
from
d928c50 to
00ec290
Compare
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Dec 5, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Reviewed By: kevinwilfong Differential Revision: D51417731
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Dec 5, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Reviewed By: kevinwilfong Differential Revision: D51417731
laithsakka
force-pushed
the
export-D51417731
branch
from
00ec290 to
bdb8554
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Dec 5, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Reviewed By: kevinwilfong Differential Revision: D51417731
laithsakka
force-pushed
the
export-D51417731
branch
from
bdb8554 to
d31e1da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
laithsakka
force-pushed
the
export-D51417731
branch
from
d31e1da to
2e43122
Compare
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Dec 6, 2023
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Reviewed By: kevinwilfong Differential Revision: D51417731
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
…Runner (facebookincubator#7634) Summary: Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test. Instead of ExpressionFuzzerVerifier reading the options from global flags this diff add ExpressionFuzzerVerifier::Options. Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier. With this change there is no more global configs controlling ExpressionFuzzerVerifier or ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only. Reviewed By: kevinwilfong Differential Revision: D51417731
laithsakka
force-pushed
the
export-D51417731
branch
from
2e43122 to
f32c477
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417731 |
|
This pull request has been merged in 0c46847. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fuzzer runner is the component that wraps ExpressionFuzzerVerifier into a unit test.
Instead of ExpressionFuzzerVerifier reading the options from global flags this diff
add ExpressionFuzzerVerifier::Options.
Fuzzer runner will read all configs and pass it to ExpressionFuzzerVerifier.
With this change there is no more global configs controlling ExpressionFuzzerVerifier or
ExpressionFuzzer. All config reading happens in FuzzerRunner.cpp only.
Differential Revision: D51417731