Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linux-presto-fuzzer-run CI build failure #7694

Closed
wants to merge 1 commit into from

Conversation

majetideepak
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 3e1a31d
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/655e0e5f5eb73600082165cc

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2023
@majetideepak majetideepak changed the title Fix Fuzzer Build Fix linux-presto-fuzzer-run CI build failure Nov 22, 2023
Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do it :)

@pedroerp
Copy link
Contributor

Can you comment on why we need to explicitly specify we want DuckDB bundled? Is it because sometimes there is DuckDB already installed in the system?

@facebook-github-bot
Copy link
Contributor

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@assignUser
Copy link
Collaborator

@pedroerp on that job we force the use of system dependencies and ddb is not installed in that image (something we can fix in a follow up)

@facebook-github-bot
Copy link
Contributor

@pedroerp merged this pull request in ba1b6a2.

Copy link

Conbench analyzed the 1 benchmark run on commit ba1b6a22.

There were 2 benchmark results indicating a performance regression:

The full Conbench report has more details.

@majetideepak majetideepak deleted the fix-build branch January 3, 2024 13:55
@@ -460,6 +460,7 @@ jobs:
environment:
VELOX_DEPENDENCY_SOURCE: SYSTEM
simdjson_SOURCE: BUNDLED
DuckDB_SOURCE: BUNDLED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using BUNDLED and not SYSTEM here.

I believe this change (inadvertently) broken join fuzzer CI runs: #7943

CC: @kgpai

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbasmanova, as @assignUser mentioned, there is no DuckDB installed in the system.
But it turned out to be costly because of the Debug mode build.

@mbasmanova
Copy link
Contributor

Can you comment on why we need to explicitly specify we want DuckDB bundled? Is it because sometimes there is DuckDB already installed in the system?

I wish we fixed that. It would have save me long hours debugging #7943 which happens only if DuckDB is build in debug mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants