-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linux-presto-fuzzer-run CI build failure #7694
Conversation
✅ Deploy Preview for meta-velox canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should do it :)
Can you comment on why we need to explicitly specify we want DuckDB bundled? Is it because sometimes there is DuckDB already installed in the system? |
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@pedroerp on that job we force the use of system dependencies and ddb is not installed in that image (something we can fix in a follow up) |
Conbench analyzed the 1 benchmark run on commit There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. |
@@ -460,6 +460,7 @@ jobs: | |||
environment: | |||
VELOX_DEPENDENCY_SOURCE: SYSTEM | |||
simdjson_SOURCE: BUNDLED | |||
DuckDB_SOURCE: BUNDLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbasmanova, as @assignUser mentioned, there is no DuckDB installed in the system.
But it turned out to be costly because of the Debug mode build.
I wish we fixed that. It would have save me long hours debugging #7943 which happens only if DuckDB is build in debug mode. |
No description provided.