Ensure regex authority is matched to fix sanitizer arrays #7866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51822902 |
kgpai
force-pushed
the
export-D51822902
branch
from
a48dbe1 to
38e099c
Compare
kgpai
added a commit
to kgpai/velox-1
that referenced
this pull request
Dec 6, 2023
…cubator#7866) Summary: It is possible to trigger address sanitizer when passed garbage strings in matchAuthorityAndPath function. We need to ensure that subgroups are actually matched, since accessing an unmatched string can lead to asan errors. Differential Revision: D51822902
|
This pull request was exported from Phabricator. Differential Revision: D51822902 |
kgpai
force-pushed
the
export-D51822902
branch
from
38e099c to
f3a088e
Compare
kgpai
added a commit
to kgpai/velox-1
that referenced
this pull request
Dec 6, 2023
…cubator#7866) Summary: It is possible to trigger address sanitizer when passed garbage strings in matchAuthorityAndPath function. We need to ensure that subgroups are actually matched, since accessing an unmatched string can lead to asan errors. Differential Revision: D51822902
|
This pull request was exported from Phabricator. Differential Revision: D51822902 |
kgpai
force-pushed
the
export-D51822902
branch
from
f3a088e to
9bef98c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51822902 |
kgpai
added a commit
to kgpai/velox-1
that referenced
this pull request
Dec 6, 2023
…sto functions (facebookincubator#7866) Summary: It is possible to trigger address sanitizer when passed garbage strings in matchAuthorityAndPath function. We need to ensure that subgroups are actually matched, since accessing an unmatched string can lead to asan errors. Differential Revision: D51822902
kgpai
force-pushed
the
export-D51822902
branch
from
9bef98c to
11a1d75
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51822902 |
kgpai
added a commit
to kgpai/velox-1
that referenced
this pull request
Dec 6, 2023
…sto functions (facebookincubator#7866) Summary: It is possible to trigger address sanitizer when passed garbage strings in matchAuthorityAndPath function. We need to ensure that subgroups are actually matched, since accessing an unmatched string can lead to asan errors. Differential Revision: D51822902
kgpai
force-pushed
the
export-D51822902
branch
from
11a1d75 to
5590a19
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51822902 |
kgpai
force-pushed
the
export-D51822902
branch
from
5590a19 to
d9a9698
Compare
kgpai
added a commit
to kgpai/velox-1
that referenced
this pull request
Dec 6, 2023
…sto functions (facebookincubator#7866) Summary: It is possible to trigger address sanitizer when passed garbage strings in matchAuthorityAndPath function. We need to ensure that subgroups are actually matched, since accessing an unmatched string can lead to asan errors. Differential Revision: D51822902
|
This pull request was exported from Phabricator. Differential Revision: D51822902 |
kgpai
force-pushed
the
export-D51822902
branch
from
d9a9698 to
9b23dc4
Compare
kgpai
added a commit
to kgpai/velox-1
that referenced
this pull request
Dec 6, 2023
…sto functions (facebookincubator#7866) Summary: It is possible to trigger address sanitizer when passed garbage strings in matchAuthorityAndPath function. We need to ensure that subgroups are actually matched, since accessing an unmatched string can lead to asan errors. Differential Revision: D51822902
|
This pull request was exported from Phabricator. Differential Revision: D51822902 |
kgpai
force-pushed
the
export-D51822902
branch
from
9b23dc4 to
682a97b
Compare
kgpai
added a commit
to kgpai/velox-1
that referenced
this pull request
Dec 7, 2023
…sto functions (facebookincubator#7866) Summary: It is possible to trigger address sanitizer when passed garbage strings in matchAuthorityAndPath function. We need to ensure that subgroups are actually matched, since accessing an unmatched string can lead to asan errors. Differential Revision: D51822902
|
This pull request was exported from Phabricator. Differential Revision: D51822902 |
kgpai
force-pushed
the
export-D51822902
branch
from
682a97b to
cbc040d
Compare
kgpai
added a commit
to kgpai/velox-1
that referenced
this pull request
Dec 7, 2023
…sto functions (facebookincubator#7866) Summary: It is possible to trigger address sanitizer when passed garbage strings in matchAuthorityAndPath function. We need to ensure that subgroups are actually matched, since accessing an unmatched string can lead to asan errors. Differential Revision: D51822902
|
This pull request was exported from Phabricator. Differential Revision: D51822902 |
kgpai
force-pushed
the
export-D51822902
branch
from
cbc040d to
6dd1b29
Compare
kgpai
added a commit
to kgpai/velox-1
that referenced
this pull request
Dec 7, 2023
…sto functions (facebookincubator#7866) Summary: It is possible to trigger address sanitizer when passed garbage strings in matchAuthorityAndPath function. We need to ensure that subgroups are actually matched, since accessing an unmatched string can lead to asan errors. Reviewed By: mbasmanova Differential Revision: D51822902
|
This pull request was exported from Phabricator. Differential Revision: D51822902 |
…sto functions (facebookincubator#7866) Summary: It is possible to trigger address sanitizer when passed garbage strings in matchAuthorityAndPath function. We need to ensure that subgroups are actually matched, since accessing an unmatched string can lead to asan errors. Reviewed By: mbasmanova Differential Revision: D51822902
kgpai
force-pushed
the
export-D51822902
branch
from
6dd1b29 to
4c4fc20
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51822902 |
|
This pull request has been merged in 61ab60d. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: It is possible to trigger address sanitizer when passed garbage strings in matchAuthorityAndPath function. We need to ensure that subgroups are actually matched, since accessing an unmatched string can lead to asan errors.
Differential Revision: D51822902