make skipFunctions, onlyFunctions, and specialForms as ExpressionFuzzer options. #7882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51856248 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Dec 5, 2023
…er options. (facebookincubator#7882) Summary: More refactoring for the expression fuzzer. 1) Push the skipFunctions, onlyFunctions, and specialForms as ExpressionFuzzer options. 2) FuzzerRunner: just a tool that wrap ExpressionFuzzerVerifier into a unit test. 3) Move the comment from FuzzerRunner class to ExpressionFuzzerVerifier since it describes the later. Next diff : 4) Move all the flags from ExpressionFuzzerVerifier to FuzzerRunner and pass them through ExpressionFuzzerVerifier::Options . 1. spark fuzzer used to only support and, or not it uses all of them "and,or,cast,coalesce,if,switch". Differential Revision: D51856248
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Dec 5, 2023
…er options. (facebookincubator#7882) Summary: More refactoring for the expression fuzzer. 1) Push the skipFunctions, onlyFunctions, and specialForms as ExpressionFuzzer options. 2) FuzzerRunner: just a tool that wrap ExpressionFuzzerVerifier into a unit test. 3) Move the comment from FuzzerRunner class to ExpressionFuzzerVerifier since it describes the later. Next diff : 4) Move all the flags from ExpressionFuzzerVerifier to FuzzerRunner and pass them through ExpressionFuzzerVerifier::Options . 1. spark fuzzer used to only support and, or not it uses all of them "and,or,cast,coalesce,if,switch". Differential Revision: D51856248
laithsakka
force-pushed
the
export-D51856248
branch
from
e5ded1c to
7c890ce
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51856248 |
…er options. (facebookincubator#7882) Summary: More refactoring for the expression fuzzer. 1) Push the skipFunctions, onlyFunctions, and specialForms as ExpressionFuzzer options. 2) FuzzerRunner: just a tool that wrap ExpressionFuzzerVerifier into a unit test. 3) Move the comment from FuzzerRunner class to ExpressionFuzzerVerifier since it describes the later. Next diff : 4) Move all the flags from ExpressionFuzzerVerifier to FuzzerRunner and pass them through ExpressionFuzzerVerifier::Options . 1. spark fuzzer used to only support and, or not it uses all of them "and,or,cast,coalesce,if,switch". Differential Revision: D51856248
laithsakka
force-pushed
the
export-D51856248
branch
from
7c890ce to
222840c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51856248 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Dec 5, 2023
…er options. (facebookincubator#7882) Summary: More refactoring for the expression fuzzer. 1) Push the skipFunctions, onlyFunctions, and specialForms as ExpressionFuzzer options. 2) FuzzerRunner: just a tool that wrap ExpressionFuzzerVerifier into a unit test. 3) Move the comment from FuzzerRunner class to ExpressionFuzzerVerifier since it describes the later. Next diff : 4) Move all the flags from ExpressionFuzzerVerifier to FuzzerRunner and pass them through ExpressionFuzzerVerifier::Options . 1. spark fuzzer used to only support and, or not it uses all of them "and,or,cast,coalesce,if,switch". Differential Revision: D51856248
|
This pull request has been merged in e963545. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
More refactoring for the expression fuzzer.
Next diff :
4) Move all the flags from ExpressionFuzzerVerifier to FuzzerRunner and pass them through ExpressionFuzzerVerifier::Options .
Differential Revision: D51856248