Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization API for set of rows #7883

Closed
wants to merge 1 commit into from
Closed

Add serialization API for set of rows #7883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions velox/serializers/CompactRowSerializer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ namespace facebook::velox::serializer {
void CompactRowVectorSerde::estimateSerializedSize(
VectorPtr /* vector */,
const folly::Range<const IndexRange*>& /* ranges */,
vector_size_t** /* sizes */) {
vector_size_t** /* sizes */,
Scratch& /*scratch*/) {
VELOX_UNSUPPORTED();
}

Expand All @@ -36,7 +37,8 @@ class CompactRowVectorSerializer : public VectorSerializer {

void append(
const RowVectorPtr& vector,
const folly::Range<const IndexRange*>& ranges) override {
const folly::Range<const IndexRange*>& ranges,
Scratch& scratch) override {
size_t totalSize = 0;
row::CompactRow row(vector);
if (auto fixedRowSize =
Expand Down
3 changes: 2 additions & 1 deletion velox/serializers/CompactRowSerializer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ class CompactRowVectorSerde : public VectorSerde {
void estimateSerializedSize(
VectorPtr vector,
const folly::Range<const IndexRange*>& ranges,
vector_size_t** sizes) override;
vector_size_t** sizes,
Scratch& scratch) override;

// This method is not used in production code. It is only used to
// support round-trip tests for deserialization.
Expand Down
Loading