Fix function signature of approx_distinct(DECIMAL(a_precision,a_scale)) #7905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stinct aggregate function"" (facebookincubator#7904) Summary: Pull Request resolved: facebookincubator#7904 Differential Revision: D51913350
Summary: Integer parameters of decimal type should be registered through .integerVariable() instead of .typeVariable() in function signatures. This is needed for aggregation fuzzer to skip these signatures because integer parameters are not supported in ArgumentTypeFuzzer yet. This diff fixes the function signature of approx_distinct(DECIMAL(a_precision,a_scale)) and approx_distinct(DECIMAL(a_precision,a_scale),double). This diff also fixes a small bug in AggregationFuzzer in the printing of skipped function signature names. This diff fixes facebookincubator#7895. Differential Revision: D51904043
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51904043 |
|
This pull request has been merged in debe03c. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Integer parameters of decimal type should be registered through .integerVariable() instead of
.typeVariable() in function signatures. This is needed for aggregation fuzzer to skip these
signatures because integer parameters are not supported in ArgumentTypeFuzzer yet. This
diff fixes the function signature of approx_distinct(DECIMAL(a_precision,a_scale)) and
approx_distinct(DECIMAL(a_precision,a_scale),double). This diff also fixes a small bug in
AggregationFuzzer in the printing of skipped function signature names.
This diff fixes #7895.
Differential Revision: D51904043