Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set task wait timeout to 5 mins by default and docs fixes #7911

Closed
wants to merge 1 commit into from
Closed

Set task wait timeout to 5 mins by default and docs fixes #7911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions velox/common/memory/Memory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ struct MemoryManagerOptions {

/// Specifies the max time to wait for memory reclaim by arbitration. The
/// memory reclaim might fail if the max wait time has exceeded. If it is
/// zero, then there is no timeout.
uint64_t memoryReclaimWaitMs{0};
/// zero, then there is no timeout. The default is 5 mins.
uint64_t memoryReclaimWaitMs{300'000};

/// Provided by the query system to validate the state after a memory pool
/// enters arbitration if not null. For instance, Prestissimo provides
Expand Down
2 changes: 1 addition & 1 deletion velox/docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Velox Documentation
functions
spark_functions
configs
stats
metrics
bindings/python/README_generated_pyvelox
develop
programming-guide
2 changes: 2 additions & 0 deletions velox/docs/stats.rst → velox/docs/metrics.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ implementation of BaseStatsReporter is required to integrate with a specific
monitoring service. The metric aggregation granularity and export interval are
also configured based on the actual used monitoring service.

Velox supports five metric types:

**Count**: tracks the count of events, such as the number of query failures.

**Sum**: tracks the sum of event data point values, such as sum of query scan
Expand Down