Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test OSS CI #7913

Closed
Closed

Conversation

mbasmanova
Copy link
Contributor

Summary: Run OSS CI.

Differential Revision: D51940660

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit b40bab0
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6571c37e5539d50008227d9d

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 7, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51940660

@mbasmanova
Copy link
Contributor Author

@duanmeng Meng, I'm not able to land #7859 as it seems to be causing circular dependency somewhere. I moved the new function from AggregationUtil.h to AggregationInfo.h. See changes in this PR. If this works and if you are Ok with this change, I'll land it. Thanks.

duanmeng and others added 2 commits December 7, 2023 05:05
…ubator#7859)

Summary:
Refactor HashAggregation to extract toAggregateInfo(AggregationNode).

Use the new function in StreamingAggregation to reduce copy-paste.

Part of facebookincubator#7665

Pull Request resolved: facebookincubator#7859

Differential Revision: D51895447

Pulled By: mbasmanova

fbshipit-source-id: 162a5dfffacdedc82c0cc39c30fe2a9f60464a23
Summary:
Pull Request resolved: facebookincubator#7913

Run OSS CI.

Differential Revision: D51940660

fbshipit-source-id: a50cd4bd7c3c407e33fca194c369f7b28833f3da
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51940660

@duanmeng
Copy link
Collaborator

duanmeng commented Dec 7, 2023

@mbasmanova Sure, no problem. Thanks:)

@mbasmanova mbasmanova closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants