Fix parallel build overflow for last bucket #7919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A parallel build inserts one range of buckets per thread. If an insert does not fit in the last bucket in the range, it is added to overflows. The overflows are inserted sequentially at the end of the build. When inserting overflows, htere are no partition bounds and as long as there is at least one free slot the insert cannot fail. However, when inserting the overflows, the upper bound of the partition must be -1 to indicate no bounds. If it is sizeMask + 1 and the last bucket is full, the insert cannot wrap around to the first bucket like it should.
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mbasmanova
reviewed
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A parallel build inserts one range of buckets per thread. If an insert does not fit in the last bucket in the range, it is added to overflows. The overflows are inserted sequentially at the end of the build. When inserting overflows, there are no partition bounds and as long as there is at least one free slot the insert cannot fail.
However, when inserting the overflows, the upper bound of the partition must be -1 to indicate no bounds. If it is sizeMask + 1 and the last bucket is full, the insert cannot wrap around to the first bucket like it should.
Fixes #3874