Add Decimal support to set_agg and set_union #7936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
aditi-pandit
reviewed
Dec 8, 2023
rrando901
force-pushed
the
setAggUnion-HugeInt
branch
3 times, most recently
from
5122717 to
cedb8d6
Compare
rrando901
force-pushed
the
setAggUnion-HugeInt
branch
from
cedb8d6 to
09dbf26
Compare
czentgr
approved these changes
Dec 11, 2023
|
@aditi-pandit Can you help take a look? |
rrando901
force-pushed
the
setAggUnion-HugeInt
branch
from
09dbf26 to
829978c
Compare
|
@rrando901 : Your build has a fuzzer failure. Please can you rebase your code and try again. Also create an issue for the fuzzer failure if needed. |
rrando901
force-pushed
the
setAggUnion-HugeInt
branch
from
829978c to
515dd6d
Compare
|
@aditi-pandit Rebased code with the latest from main. There is a fuzzer failure in Looks like there are two issues opened for this already: |
|
Hi @Yuhta. When you get a chance, could you take a look at these changes? |
rrando901
force-pushed
the
setAggUnion-HugeInt
branch
from
515dd6d to
45fccbd
Compare
|
Rebased PR @aditi-pandit @Yuhta |
|
@aditi-pandit please follow up, thanks! |
rrando901
force-pushed
the
setAggUnion-HugeInt
branch
from
45fccbd to
77ae46b
Compare
|
@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delivers #7935