Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-sdk-cpp version to 1.11.169 (from 1.10.57) #8099

Closed
wants to merge 1 commit into from

Conversation

yma11
Copy link
Contributor

@yma11 yma11 commented Dec 19, 2023

There is deadlock issue in current aws-sdk-cpp version, refer link. And some later version also has memory leak issue, like 1.11.4. Here we update to version 1.11.169.

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit d979f03
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/65814d9b034eeb00089bec50

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 19, 2023
@yma11
Copy link
Contributor Author

yma11 commented Dec 20, 2023

Hi @mbasmanova, will it be okay for you to merge this PR? Thanks.

@mbasmanova mbasmanova changed the title update aws-sdk-cpp version to 1.11.169 Update aws-sdk-cpp version to 1.11.169 (from 1.10.57) Dec 20, 2023
@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mbasmanova
Copy link
Contributor

@yma11 Thanks. I'll merge. In the future, for similar changes, use this pattern for PR titles: "Update xxx version to N (from M)".

@facebook-github-bot
Copy link
Contributor

@mbasmanova merged this pull request in 6b17ea5.

Copy link

Conbench analyzed the 1 benchmark run on commit 6b17ea51.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@yma11 yma11 deleted the aws-sdk-version branch January 24, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants