Do Not Merge : Upgrade fmt to 10.1.1 (from 8.0.1) (#7941) #8434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
kgpai
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 18, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: ae9d58575d416519d8d0447380564083da88b4a3
kgpai
force-pushed
the
export-D52880145
branch
from
29f260a to
15be791
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 18, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: a3ff1859a0df00a9b49f400665f0b16d6f27acba
kgpai
force-pushed
the
export-D52880145
branch
from
15be791 to
f3c0fb5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
force-pushed
the
export-D52880145
branch
from
f3c0fb5 to
a28e720
Compare
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: ea6797059930351aad170eee19026b183d352fd2
Yuhta
approved these changes
Jan 19, 2024
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
force-pushed
the
export-D52880145
branch
from
a28e720 to
3ec83ba
Compare
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Reviewed By: Yuhta Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: b0724355657f2303d115da5b82572f1cbf3ada72
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Reviewed By: Yuhta Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: 773c88c41c4b7c786fbf108e4257cfe7c3cc2594
kgpai
force-pushed
the
export-D52880145
branch
from
3ec83ba to
9c36b22
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Reviewed By: Yuhta Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: 68db12f6c67e968562122d324d0a9f9e06ea1f62
kgpai
force-pushed
the
export-D52880145
branch
from
9c36b22 to
6c1ff47
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Reviewed By: Yuhta Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: 399ff634da95321a05b342adb2ead9f14792ed5c
kgpai
force-pushed
the
export-D52880145
branch
from
6c1ff47 to
a1b7a7a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Reviewed By: Yuhta Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: 0c4d1ce4f18eca10f69cea7301cc849680767b95
kgpai
force-pushed
the
export-D52880145
branch
from
a1b7a7a to
82d0ac2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Reviewed By: Yuhta Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: 1d8704484a14b9f03ee8c709ed283d5e586d35c4
kgpai
force-pushed
the
export-D52880145
branch
from
82d0ac2 to
47307ea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 20, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Reviewed By: Yuhta Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: 1a1c070399a33d0202b284f045db3ab5081966cb
kgpai
force-pushed
the
export-D52880145
branch
from
47307ea to
e7bcaa3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 20, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Reviewed By: Yuhta Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: e847ab3bb268d950a1d82ad2f6b3cd9d18baa70d
kgpai
force-pushed
the
export-D52880145
branch
from
e7bcaa3 to
d7f5ccb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 20, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Reviewed By: Yuhta Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: f49db1561006fdd5c876b28a727f104d5aab4a58
kgpai
force-pushed
the
export-D52880145
branch
from
d7f5ccb to
e048b78
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 20, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Reviewed By: Yuhta Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: 4c8aa99b6be6a7dc1d2f4854145830f1254fbd2c
kgpai
force-pushed
the
export-D52880145
branch
from
e048b78 to
826ee28
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Jan 20, 2024
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Reviewed By: Yuhta Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: cf96653f76ff2d3c8c802c8230107515a36cb440
kgpai
force-pushed
the
export-D52880145
branch
from
826ee28 to
ddfc19a
Compare
Summary: Pull Request resolved: facebookincubator#8434 fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during facebookincubator#7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes facebookincubator#7896 Pull Request resolved: facebookincubator#7941 Reviewed By: Yuhta Differential Revision: D52880145 Pulled By: kgpai fbshipit-source-id: 8f7e8d8d69ac3260a040eb8ae0b43432c87f6841
|
This pull request was exported from Phabricator. Differential Revision: D52880145 |
kgpai
force-pushed
the
export-D52880145
branch
from
ddfc19a to
9861088
Compare
|
#7941 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Copy of @assignUser's PR with some changes to get OSS CI Signals. Its not meant for merging.
I will close this PR when the original PR(below) is merged and closed.
Summary:
fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during #7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1).
Closes #7896
Differential Revision: D52880145
Pulled By: kgpai