-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setup-circleci.sh and update setup scripts #8454
Closed
+152
−173
Closed
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
da0e612
Remove setup-circleci.sh and update setup-centos8.sh
majetideepak f39222a
cleanup
majetideepak e9add63
use devtools set
assignUser ff95316
Add minio
majetideepak 4b28768
fix adapters.sh and add Minio build
majetideepak 6af0963
address review comments
majetideepak 0457ae8
fix minio setup
majetideepak ffa0879
Add fbthrift/mvfst/fizz/wangle and other dependencies to velox.
kgpai 36ec5a8
Fix MacOS command
majetideepak f0bb998
Remove folly fix
majetideepak aaad1c0
Fix MacOS setup script
majetideepak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add fbthrift/mvfst/fizz/wangle and other dependencies to velox.
commit ffa0879ea9c66e4eec62e99ff92ee8b234a0e5e5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,8 @@ NPROC=$(getconf _NPROCESSORS_ONLN) | |
DEPENDENCY_DIR=${DEPENDENCY_DIR:-$(pwd)} | ||
MACOS_DEPS="ninja flex bison cmake ccache protobuf@21 icu4c boost gflags glog libevent lz4 lzo snappy xz zstd [email protected]" | ||
|
||
FB_OS_VERSION="v2023.12.04.00" | ||
|
||
function run_and_time { | ||
time "$@" || (echo "Failed to run $* ." ; exit 1 ) | ||
{ echo "+ Finished running $*"; } 2> /dev/null | ||
|
@@ -93,11 +95,36 @@ function install_fmt { | |
} | ||
|
||
function install_folly { | ||
github_checkout facebook/folly "v2023.12.04.00" | ||
github_checkout facebook/folly "${FB_OS_VERSION}" | ||
OPENSSL_ROOT_DIR=$(brew --prefix [email protected]) \ | ||
cmake_install -DBUILD_TESTS=OFF -DFOLLY_HAVE_INT128_T=ON | ||
} | ||
|
||
function install_fizz { | ||
github_checkout facebookincubator/fizz "${FB_OS_VERSION}" | ||
OPENSSL_ROOT_DIR=$(brew --prefix [email protected]) \ | ||
cmake_install -DBUILD_TESTS=OFF -S fizz | ||
} | ||
|
||
function install_wangle { | ||
github_checkout facebook/wangle "${FB_OS_VERSION}" | ||
OPENSSL_ROOT_DIR=$(brew --prefix [email protected]) \ | ||
cmake_install -DBUILD_TESTS=OFF -S wangle | ||
} | ||
|
||
majetideepak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
function install_mvfst { | ||
github_checkout facebook/mvfst "${FB_OS_VERSION}" | ||
OPENSSL_ROOT_DIR=$(brew --prefix [email protected]) \ | ||
cmake_install -DBUILD_TESTS=OFF -DFOLLY_HAVE_INT128_T=ON | ||
} | ||
|
||
|
||
function install_fbthrift { | ||
github_checkout facebook/fbthrift "${FB_OS_VERSION}" | ||
OPENSSL_ROOT_DIR=$(brew --prefix [email protected]) \ | ||
cmake_install -DBUILD_TESTS=OFF | ||
} | ||
|
||
function install_double_conversion { | ||
github_checkout google/double-conversion v3.1.5 | ||
cmake_install -DBUILD_TESTING=OFF | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@assignUser do we still need the OPENSSL_ROOT_DIR variable with the upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this. We infact have to remove this variable. Fizz is failing to build otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to build this with openssl root dir etc..
The error you are seeing is because its picking up openssl 3 binary but building against openssl 1 header.. If it builds against openssl 1 binary you wont see that issue.