Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Centos8 setup script #8683

Closed

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Feb 6, 2024

Improve centos8 setup script to match the MacOS and Ubuntu setup scripts.
Move common functions to setup-helper-functions.sh

@majetideepak majetideepak requested a review from kgpai February 6, 2024 09:05
Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 01ba0f5
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/65c5aac3e004d600082e080b

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2024
@majetideepak majetideepak force-pushed the add-install-velox branch 2 times, most recently from 44a08da to 5bde304 Compare February 6, 2024 09:14
Copy link
Contributor

@kgpai kgpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Deepak, this makes the setup scripts more consistent .

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in 159e7e9.

Copy link

Conbench analyzed the 1 benchmark run on commit 159e7e97.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants