Fix install_conda in setup-ubuntu.sh to consider the CPU architecture #8706
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@kgpai @majetideepak can you please review this? Thanks! |
|
Thank you @majetideepak for the review! @mbasmanova can you please help with completing this? |
There was a problem hiding this comment.
@acvictor @majetideepak Would it be possible to update PR title and description to clarify what these changes are about? What was the problem and what is the solution?
@kgpai Krishna, would you help review and merge this PR?
majetideepak
changed the title
|
@mbasmanova I added a description. Thanks. |
|
@majetideepak Thank you, Deepak. |
|
@majetideepak @acvictor We are having some issues importing PRs today; we hope to fix this soon, please give a day or two to merge and land these PRs. |
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@acvictor Would you rebase so we can merge? |
Done! |
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 5d1d2a3. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
The function install_conda in setup_ubuntu.sh always downloads the conda package corresponding to
the CPU architecture x86_64.
Fix the function to download the conda package based on the actual CPU architecture (x86_64 or aarch64).
Resolves #8453