Fix createTimestampVector without nulls buffer #8955
Closed
+46
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
ViggoC
approved these changes
Mar 5, 2024
|
|
||
| auto output = importFromArrow(arrowSchema1, arrowArray1, pool_.get()); | ||
| assertVectorContent(inputValues, output, arrowArray1.null_count); | ||
| if constexpr (std::is_same_v<TOutput, Timestamp>) { | ||
| std::vector<std::optional<Timestamp>> expectedValues; |
There was a problem hiding this comment.
Overall LGTM.
nit: it would be better to extract the detail of this brach to a separate function.
rui-mo
force-pushed
the
wip_ts_vector
branch
2 times, most recently
from
0027168 to
9e8fda9
Compare
|
Hi @mbasmanova @Yuhta, would you like to review this PR? Thanks. |
mbasmanova
reviewed
Mar 5, 2024
Yuhta
reviewed
Mar 5, 2024
| @@ -1135,38 +1135,45 @@ class ArrowBridgeArrayImportTest : public ArrowBridgeArrayExportTest { | |||
| "ttn", {Timestamp(0, 0), std::nullopt, Timestamp(1699308257, 1234)}); | |||
| } | |||
|
|
|||
| void testImportWithoutNullsBuffer() { | |||
| std::vector<std::optional<int64_t>> inputValues = {1, 2, 3, 4, 5}; | |||
| template <typename TInput, typename TOutput> | |||
There was a problem hiding this comment.
nit: TInput can be inferred from inputValues so we can move it to end of the type parameter list and omit it at call sites.
There was a problem hiding this comment.
Thanks for your suggestion. Updated.
rui-mo
force-pushed
the
wip_ts_vector
branch
2 times, most recently
from
9528e9b to
6ecdbb6
Compare
|
@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: This PR fixes the failure of `createTimestampVector` when nulls buffer is nullptr. facebookincubator#7625 (comment) Pull Request resolved: facebookincubator#8955 Reviewed By: xiaoxmeng Differential Revision: D54590232 Pulled By: Yuhta fbshipit-source-id: a41846bbad9f51f4569623b013044c3c1feac24f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the failure of
createTimestampVectorwhen nulls buffer isnullptr.
#7625 (comment)