Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies of GCS #8960

Closed
wants to merge 1 commit into from

Conversation

tigrux
Copy link
Contributor

@tigrux tigrux commented Mar 5, 2024

Small change to update dependencies of GCS, that have not been updated in almost a year.
Fixes #8963.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2024
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit b7e6952
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/65e7401a2441c00008e4e7c8

@tigrux tigrux changed the title [WIP] Update dependencies of GCS Update dependencies of GCS Mar 5, 2024
@tigrux
Copy link
Contributor Author

tigrux commented Mar 5, 2024

@majetideepak Hello, we are in the process of adding new connectors and the first step is to update GCS. Thanks.

Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tigrux Changes look good! Can you share what the new connectors are?

@tigrux
Copy link
Contributor Author

tigrux commented Mar 6, 2024

@tigrux Changes look good! Can you share what the new connectors are?

Surely, we are planning to add support for Google BigQuery, and then enable it in Gluten as we did before for GCS.

@tigrux
Copy link
Contributor Author

tigrux commented Mar 8, 2024

@kgpai Could you take a look at this PR please?
Thanks.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in 21242cb.

@tigrux tigrux deleted the update_gcs_deps branch June 4, 2024 15:50
Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this pull request Jun 7, 2024
Summary:
Small change to update dependencies of GCS, that have not been updated in almost a year.
Fixes facebookincubator#8963.

Pull Request resolved: facebookincubator#8960

Reviewed By: Yuhta

Differential Revision: D54694659

Pulled By: kgpai

fbshipit-source-id: 18999aff4801449d3833ce4ae87ccd0615115583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies of GCS have not been updated for nearly a year
5 participants