Fix a task early termination with group execution #9047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
spershin
approved these changes
Mar 12, 2024
|
@xiaoxmeng merged this pull request in 86f559c. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…9047) Summary: A grouped execution task might receive no more splits for all its group before the task startup. If that happens, the existing no more split function checks if a grouped execution task has finished execution or not by checking if the total number of finished tasks equals to the total number of tasks (Task::checkNoMoreSplitGroupsLocked). If it equals, then it will terminate the task. If the task hasn't started, then numDriversPerSplitGroup_ is left as zero, then the task finish condition is always met and the task is terminated as unexpected. This PR fixes the issue by checking if numDriversPerSplitGroup_ has been set by task startup or not under grouped execution mode. It won't check task finish if numDriversPerSplitGroup_ is not set. Verifies with unit test. Pull Request resolved: facebookincubator#9047 Reviewed By: spershin Differential Revision: D54792360 Pulled By: xiaoxmeng fbshipit-source-id: 161439aae2b5659139aff5fdf2bf30740f89bfcb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A grouped execution task might receive no more splits for all its group before the task startup.
If that happens, the existing no more split function checks if a grouped execution task has finished
execution or not by checking if the total number of finished tasks equals to the total number of tasks (Task::checkNoMoreSplitGroupsLocked). If it equals, then it will terminate the task. If the task
hasn't started, then numDriversPerSplitGroup_ is left as zero, then the task finish condition is always
met and the task is terminated as unexpected.
This PR fixes the issue by checking if numDriversPerSplitGroup_ has been set by task startup or not
under grouped execution mode. It won't check task finish if numDriversPerSplitGroup_ is not set.
Verifies with unit test.