Add day(interval) Presto function #9054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54830164 |
✅ Deploy Preview for meta-velox canceled.
|
kagamiori
approved these changes
Mar 13, 2024
|
|
||
| EXPECT_EQ(1, day(kMillisInDay)); | ||
| EXPECT_EQ(1, day(kMillisInDay + kMillisInHour)); | ||
| EXPECT_EQ(10, day(10 * kMillisInDay + 7 * kMillisInHour)); |
There was a problem hiding this comment.
Can interval be negative? Shall we add some test cases with negative values?
There was a problem hiding this comment.
It can. Added a test.
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 13, 2024
Summary: Pull Request resolved: facebookincubator#9054 Reviewed By: kagamiori Differential Revision: D54830164
mbasmanova
force-pushed
the
export-D54830164
branch
from
efa16de to
e73870a
Compare
Summary: Pull Request resolved: facebookincubator#9054 Reviewed By: kagamiori Differential Revision: D54830164
|
This pull request was exported from Phabricator. Differential Revision: D54830164 |
mbasmanova
force-pushed
the
export-D54830164
branch
from
e73870a to
6d2989f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54830164 |
xiaoxmeng
approved these changes
Mar 13, 2024
|
This pull request has been merged in 764aebd. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#9054 Reviewed By: kagamiori Differential Revision: D54830164 fbshipit-source-id: 31ebaffd75c08c5c8529435cff3e1ea1afa0421e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D54830164