Fix fbthrift build in setup-*.sh #9204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
majetideepak
approved these changes
Mar 21, 2024
|
Thank you! |
|
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: In the new fbthrift version from facebookincubator#8950 a command fails if `BUILD_SHARED_LIBS` is not explicitly set (because its empty by default). This PR explicitly sets BUILD_SHARED_LIBS when building fbthrift and also uses the correct flag to disable tests in addition to the default cmake one. Pull Request resolved: facebookincubator#9204 Reviewed By: kevinwilfong Differential Revision: D55337270 Pulled By: pedroerp fbshipit-source-id: 6d77d10e5a1ed0379f52177edf8753246b1e8a6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new fbthrift version from #8950 a command fails if
BUILD_SHARED_LIBSis not explicitly set (because its empty by default). This PR explicitly sets BUILD_SHARED_LIBS when building fbthrift and also uses the correct flag to disable tests in addition to the default cmake one.