Add nightly job to track build metrics #9460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
assignUser
force-pushed
the
build-metrics
branch
from
b28cfdf to
1ada279
Compare
kgpai
reviewed
Apr 19, 2024
| "suite": suite, | ||
| "source": f"{self.build_type}_build_metrics_time", | ||
| }, | ||
| info={}, |
There was a problem hiding this comment.
i wonder if we can capture other things like ' compiler' , compiler flags used etc ? (maybe in the next set of changes).
There was a problem hiding this comment.
We can add arbitrary metadata as tags. There might also be a build in way to capture compiler and such similar to the machine info that's already part of the results.
|
I see the same error on main: https://github.com/facebookincubator/velox/actions/runs/8797715111/job/24143218933#step:8:3300 |
kgpai
approved these changes
Apr 23, 2024
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yuhta
approved these changes
Apr 24, 2024
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: This PR adds a nightly job that collect build time and binary size metrics for a debug and release build and uploads the data to conbench. For example: https://velox-conbench.voltrondata.run/runs/BM-release-8665191090-1/ The adapters also add aggregate statistics, for time the `wall_time` is of course dependent on the number of cores so there will be clear differences between release and debug as debug runs on 16 cores (because the 8 cores don't have enough disk space for a debug build). Pull Request resolved: facebookincubator#9460 Reviewed By: Yuhta Differential Revision: D56496198 Pulled By: kgpai fbshipit-source-id: e6d0c3f83d10c053e90d1ad18532ff474eee25e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a nightly job that collect build time and binary size metrics for a debug and release build and uploads the data to conbench. For example: https://velox-conbench.voltrondata.run/runs/BM-release-8665191090-1/
The adapters also add aggregate statistics, for time the
wall_timeis of course dependent on the number of cores so there will be clear differences between release and debug as debug runs on 16 cores (because the 8 cores don't have enough disk space for a debug build).