Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setup-centos8 script to use pip3.9 #9536

Closed
wants to merge 1 commit into from
Closed

Fix setup-centos8 script to use pip3.9 #9536

wants to merge 1 commit into from

Conversation

majetideepak
Copy link
Collaborator

Use pip3.9 to install packages since python39-pip is installed.

@majetideepak majetideepak requested a review from assignUser April 18, 2024 22:33
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 18, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit f9f0cf1
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66219fbe6fe7b8000900279d

@majetideepak majetideepak changed the title Fix command to use pip3.9 Fix setup-centos8 script to use pip3.9 Apr 18, 2024
@assignUser
Copy link
Collaborator

does pip3 not default to the newest installed pip version or change based on alternatives(which I guess I didn't chang? anther reason to use python3 -m pip ...)

@majetideepak
Copy link
Collaborator Author

The setup script itself does not use alternatives. I invoked the script on a clean centos8 container and I got pip3 command not found.

@majetideepak
Copy link
Collaborator Author

I guess it is not clean after all

# alternatives --display python3
python3 - status is auto.
 link currently points to /usr/bin/python3.11
/usr/bin/python3.11 - priority 31100
 slave easy_install-3: (null)
 slave pip-3: (null)
 slave pip3: (null)
 slave pydoc-3: /usr/bin/pydoc3.11
 slave pydoc3: /usr/bin/pydoc3.11
 slave python3-config: (null)
 slave pyvenv-3: (null)
 slave python3-man: /usr/share/man/man1/python3.11.1.gz
/usr/bin/python3.9 - priority 3900
 slave easy_install-3: /usr/bin/easy_install-3.9
 slave pip-3: /usr/bin/pip-3.9
 slave pip3: /usr/bin/pip3.9
 slave pydoc-3: /usr/bin/pydoc3.9
 slave pydoc3: /usr/bin/pydoc3.9
 slave python3-config: /usr/bin/python3.9-config
 slave pyvenv-3: (null)
 slave python3-man: /usr/share/man/man1/python3.9.1.gz
Current `best' version is /usr/bin/python3.11.

@majetideepak
Copy link
Collaborator Author

python3 -m pip says

/usr/bin/python3: No module named pip

@majetideepak
Copy link
Collaborator Author

Is it not safe to use pip3.9 in the presence of other versions?

@assignUser
Copy link
Collaborator

Is it not safe to use pip3.9 in the presence of other versions?

Oh no it should, I was just wondering. But of course I only touch alternatives in the docker image so this makes sense! Sorry for the confusion^^

@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Apr 18, 2024
@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng merged this pull request in c240cf3.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit c240cf36.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@majetideepak majetideepak deleted the fix-pip-command branch May 23, 2024 06:08
Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this pull request Jun 7, 2024
@majetideepak @Joe-Abraham
Fix setup-centos8 script to use pip3.9 (facebookincubator#9536)
cefb8dc 
Summary:
Use pip3.9 to install packages since python39-pip is installed.

Pull Request resolved: facebookincubator#9536

Reviewed By: Yuhta

Differential Revision: D56332732

Pulled By: xiaoxmeng

fbshipit-source-id: b78d034e81e6f3f8b8569a1e3cf5334f40de81c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser approved these changes

@Yuhta Yuhta Yuhta approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@majetideepak @assignUser @facebook-github-bot @Yuhta