[Docs] Readme update #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
# Conflicts: # premade_scripts/vmas/config.yaml
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
facebook-github-bot
added
the
CLA Signed
matteobettini
commented
Sep 27, 2023
Comment on lines
+53
to
+57
| pip install git+https://github.com/pytorch-labs/tensordict | ||
| git clone https://github.com/pytorch/rl.git | ||
| cd rl | ||
| python setup.py develop | ||
| cd .. |
There was a problem hiding this comment.
@vmoens
This is currently the only way i am able to install torchrl nightly.
This is because of many issues:
- the MacOS compatibility prevents from using the nightly dependency
- the
torchrl._torchrlmakes it so thatpip install git+https://github.com/pytorch/rl.gitandgit clone+pip install -e .do not work
Telling the users to clone rl seems a lot to me, is there any workaround?
There was a problem hiding this comment.
sorry i missed your tag
oh yes I know about that, there's an easy fix, let me take care of it
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Signed-off-by: Matteo Bettini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started filling README contents and organizing examples