This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Model state should support PyTorch API #727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D25213283 |
Summary: Pull Request resolved: facebookresearch#727 Classy Models should work like regular PyTorch models. The `{get, set}_classy_state` functions for state are the only blockers which this diff fixes by moving over to `state_dict` and `load_state_dict`. `{get, set}_classy_state` will still work for backwards compatibility, but will call the PyTorch functions directly. Differential Revision: D25213283 fbshipit-source-id: 3cd64f530de83574174884d3b8848a1f6003f854
mannatsingh
force-pushed
the
export-D25213283
branch
from
fa59edb to
b73871e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25213283 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Classy Models should work like regular PyTorch models. The
{get, set}_classy_statefunctions for state are the only blockers which this diff fixes by moving over tostate_dictandload_state_dictDifferential Revision: D25213283