Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conda recipe #352

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

sarthakpati
Copy link

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

Fixes #349

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2022
@sarthakpati
Copy link
Author

Unsure why the unit tests are failing, since I am only doing a documentation update.

@knottb
Copy link
Contributor

knottb commented Feb 14, 2022

Thanks for this - I'll merge this once I see the recipe merge in conda-forge.

As for unit-tests those are pre-existing failures.

@sarthakpati
Copy link
Author

Oh, I put this PR only after the feedstock was created and the first builds were pushed: https://anaconda.org/conda-forge/crypten

🚀

@sarthakpati
Copy link
Author

This is ready to be merged, BTW. It is only a documentation change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add conda recipe
3 participants